rotate and perspective: scrolling up/down should increase/decrease selection circle diameter#20833
Merged
TurboGit merged 1 commit intodarktable-org:masterfrom Apr 20, 2026
Conversation
…lection circle diameter, not the other way around
TurboGit
added
bugfix
kofa73
deleted the
rotate-and-perspective-scroll-up-to-increase-selection-circle
branch
Contributor
Author
|
Thanks @TurboGit , but there's more to clean up, see #20832 (comment). We'll have to discuss this and come up with a plan. An added complication is that some enable a "natural scroll" setting, which reverses scroll direction, which they'll probably want to keep for scroll bars, but still use scroll up / down = increase / decrease size (e.g. selection circles) or value (sliders). |
Member
Yes, saw that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When editing drawn masks, scrolling up / down increases / decreases the size of the selection circle, the drawn mask, or feathering. In rotate and perspective, it works the other way around. The current PR applies the same behaviour as used in masks, up means increase, down means decrease.